Re: [PATCH] iio: Remove unused iio_device_put()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/12/2012 04:18 PM, Greg Kroah-Hartman wrote:
> On Fri, May 11, 2012 at 03:13:13PM +0200, Lars-Peter Clausen wrote:
>> This function is currently unused and we do not have a matching iio_device_get()
>> function either, so just remove it.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
>> Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> 
> No, I see a number of places it should be used.  Don't do "raw"
> put_device() calls, every one of them could be making this call instead,
> right?

Hm, right in the new inkern code there are some put_device calls on
indio_dev.dev, I missed those, sorry. But we should really add a matching
iio_device_get() as well.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux