The ring wasn't actually optional and it makes for a confusing mess in the Kconfig for this device. If it becomes optional again then we can put the configuration options back in again! Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx> --- drivers/staging/iio/adc/Kconfig | 12 +----------- drivers/staging/iio/adc/Makefile | 4 +--- drivers/staging/iio/adc/max1363.h | 18 ------------------ 3 files changed, 2 insertions(+), 32 deletions(-) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index ec006e7..c8839c3 100644 --- a/drivers/staging/iio/adc/Kconfig +++ b/drivers/staging/iio/adc/Kconfig @@ -172,8 +172,7 @@ config AD7280 config MAX1363 tristate "Maxim max1363 ADC driver" depends on I2C - select IIO_TRIGGER if IIO_BUFFER - select MAX1363_RING_BUFFER + depends on IIO_BUFFER && IIO_TRIGGER && IIO_SW_RING help Say yes here to build support for many Maxim i2c analog to digital converters (ADC). (max1361, max1362, max1363, max1364, max1036, @@ -184,15 +183,6 @@ config MAX1363 max11614, max11615, max11616, max11617, max11644, max11645, max11646, max11647) Provides direct access via sysfs. -config MAX1363_RING_BUFFER - bool "Maxim max1363: use ring buffer" - depends on MAX1363 - select IIO_BUFFER - select IIO_SW_RING - help - Say yes here to include ring buffer support in the MAX1363 - ADC driver. - config LPC32XX_ADC tristate "NXP LPC32XX ADC" depends on ARCH_LPC32XX && !TOUCHSCREEN_LPC32XX diff --git a/drivers/staging/iio/adc/Makefile b/drivers/staging/iio/adc/Makefile index 14e98b6..3fb9c8c 100644 --- a/drivers/staging/iio/adc/Makefile +++ b/drivers/staging/iio/adc/Makefile @@ -2,9 +2,7 @@ # Makefile for industrial I/O ADC drivers # -max1363-y := max1363_core.o -max1363-y += max1363_ring.o - +max1363-y := max1363_core.o max1363_ring.o obj-$(CONFIG_MAX1363) += max1363.o ad7606-y := ad7606_core.o diff --git a/drivers/staging/iio/adc/max1363.h b/drivers/staging/iio/adc/max1363.h index 2cd0112..3839cfd 100644 --- a/drivers/staging/iio/adc/max1363.h +++ b/drivers/staging/iio/adc/max1363.h @@ -151,27 +151,9 @@ const struct max1363_mode int max1363_set_scan_mode(struct max1363_state *st); -#ifdef CONFIG_MAX1363_RING_BUFFER int max1363_update_scan_mode(struct iio_dev *indio_dev, const unsigned long *scan_mask); int max1363_register_ring_funcs_and_init(struct iio_dev *indio_dev); void max1363_ring_cleanup(struct iio_dev *indio_dev); -#else /* CONFIG_MAX1363_RING_BUFFER */ -int max1363_update_scan_mode(struct iio_dev *indio_dev, - const long *scan_mask) -{ - return 0; -} - -static inline int -max1363_register_ring_funcs_and_init(struct iio_dev *indio_dev) -{ - return 0; -} - -static inline void max1363_ring_cleanup(struct iio_dev *indio_dev) -{ -} -#endif /* CONFIG_MAX1363_RING_BUFFER */ #endif /* _MAX1363_H_ */ -- 1.7.9.4 -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html