Re: [PATCH 04/14] staging:iio:accel:adis16209 unwind use of IIO_CHAN macro.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/10/2012 10:21 PM, Jonathan Cameron wrote:
> This macro is being removed to simplify ongoing maintenance
> so we need to unwind and remaining users.
> 
> Note the addition of extend_name = "supply" for the supply voltage
> adc.  This brings this driver into line with the other adis parts.
> 
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx>

The cocci patch disagrees on one occasion, but I think that's an bug in the
original driver.

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

> ---
>  drivers/staging/iio/accel/adis16209_core.c |  135 ++++++++++++++++++++--------
>  1 file changed, 100 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index a98715f..02c003f 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -408,41 +408,106 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
>  }
>  
>  static struct iio_chan_spec adis16209_channels[] = {
> [...]
> -	IIO_CHAN(IIO_ROT, 0, 1, 0, NULL, 0, IIO_MOD_X,
> -		    0,
> -		    rot, ADIS16209_SCAN_ROT,
> -		    IIO_ST('s', 14, 16, 0), 0),

> +	}, {
> +		.type = IIO_ROT,
> +		.modified = 1,

This one had indexed set instead of modified, which doesn't make any sense.
May be worth noting this in the changelog though.

> +		.channel2 = IIO_MOD_X,
> +		.address = rot,
> +		.scan_index = ADIS16209_SCAN_ROT,
> +		.scan_type = {
> +			.sign = 's',
> +			.realbits = 14,
> +			.storagebits = 16,
> +		},
> +	},
>  	IIO_CHAN_SOFT_TIMESTAMP(8)
>  };
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux