Re: [PATCH v2 5/6] staging:iio:events: Use non-atomic bitops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 2 2012, Dan Carpenter wrote:

On Thu, Feb 02, 2012 at 02:19:16PM +0300, Dan Carpenter wrote:
On Thu, Feb 02, 2012 at 10:14:25AM +0100, Lars-Peter Clausen wrote:
> I don't think there is any real performance improvement to be expected of
> this patch. If you have good a reason why non-atomic bitops should not be
> used I guess this patch could be dropped.


Actually perhaps it's better to apply this because the code is
already tricky and the double underscores serve as a reminder.
I'm fine with this change.

Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

You could also remove the "/* Does anyone care? */ from
iio_push_event() because we do care.

Ah, that one was my bad. Probably written way to late in the evening.
It  isn't meant to be a comment about the code, but rather a description
of what is being checked!  Literally 'This is checking whether there is anyone
listening'.

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux