Hi Arnd, On 17/01/2012 18:35, Arnd Bergmann wrote: > On Monday 16 January 2012, Maxime Ripard wrote: >> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> >> >> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> >> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> >> Cc: Patrice Vilchez <patrice.vilchez@xxxxxxxxx> >> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> >> Cc: Jonathan Cameron <jic23@xxxxxxxxx> >> Cc: Marek Vasut <marek.vasut@xxxxxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> > > I think I reviewed this driver before, but I don't remember any of the > details I may have complained about. I assume everything was fixed, > since the driver looks good in this version ;-) You did, and as far as I remember, you did not complained much. but actually, I've rewritten a large enough part of this driver to make the Acked-by you gave at the time at best outdated. That's why I dropped all the SoB and friends to a Cc. I mentionned it in the cover letter, but I forgot to Cc you one that one too, my bad... > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> > > Two general comments: > > * Please add a changeset description (i.e. thetext above your > Signed-off-by: line) for every patch you do. Just read a few > dozen patches that get posted to lkml to get a feeling for > what would be useful to have in there. For a new driver, it > would be helpful to know what hardware uses this driver and > what the device does there. Ok, will do. > * Over time, we will get stricter in requiring device tree > bindings for new platform devices, to replace platform_data > where appropriate. It's not required yet, but it would be nice > to describe the long-term plan in submissions that add new > platform_data but no device tree bindings. The main point of rewriting a part of it was exactly to make the transition to device-tree and single kernel image easier when the time comes. Maxime -- Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
