Re: [PATCH 2/3] staging: iio: core: add missing spaces to error output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fine.  But while we are here, isn't conventionto have error strings on
one line even if they break the 80 character limit so that they can
be grepped for?  I guess we have two logical parts here, so not too
bad...
> Signed-off-by: Manuel Stahl <manuel.stahl@xxxxxxxxxxxxxxxxx>
Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> ---
>  drivers/staging/iio/industrialio-buffer.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/industrialio-buffer.c b/drivers/staging/iio/industrialio-buffer.c
> index a03a574..f5c4999 100644
> --- a/drivers/staging/iio/industrialio-buffer.c
> +++ b/drivers/staging/iio/industrialio-buffer.c
> @@ -430,7 +430,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = indio_dev->setup_ops->preenable(indio_dev);
>  			if (ret) {
>  				printk(KERN_ERR
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "buffer preenable failed\n");
>  				goto error_ret;
>  			}
> @@ -439,7 +439,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = buffer->access->request_update(buffer);
>  			if (ret) {
>  				printk(KERN_INFO
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "buffer parameter update failed\n");
>  				goto error_ret;
>  			}
> @@ -468,7 +468,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = indio_dev->setup_ops->postenable(indio_dev);
>  			if (ret) {
>  				printk(KERN_INFO
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "postenable failed\n");
>  				if (buffer->access->unmark_in_use)
>  					buffer->access->unmark_in_use(buffer);

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux