On 12/10/2011 04:39 PM, Jonathan Cameron wrote: > This issue came to my attention whilst reviewing Maximes at91 patches. > Anyhow, we have iio_trigger->owner and iio_trigger->ops->owner. > > The first was meant to have gone away. > A couple of drivers don't provide iio_trigger->ops causing nastiness > to happen when the trigger get or put occurs. Not seen in the wild > as I don't have either of the two devices in question. > > Simple fix. Add the struture where missing and get rid of the owner field > from the iio_trigger structure. > > Any comments? > > Jonathan Looks good to me. Both patches Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > Jonathan Cameron (2): > staging:iio: Make sure all triggers have a trigger_ops for the owner > field. > staging:iio: iio_trigger contains defunct owner field. Remove it. > > drivers/staging/iio/adc/ad7192.c | 7 +++++-- > drivers/staging/iio/adc/ad7793.c | 6 +++++- > drivers/staging/iio/trigger.h | 2 -- > .../staging/iio/trigger/iio-trig-periodic-rtc.c | 1 - > 4 files changed, 10 insertions(+), 6 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html