On 11/16/2011 05:13 PM, Mark Brown wrote: > On Wed, Nov 16, 2011 at 04:28:17PM +0100, Lars-Peter Clausen wrote: >> The reg_defaults field usually points to a static per driver array, which should >> not be modified. Make requirement this explicit by making reg_defaults const. > > You should've got reams of sparse warnings from that - the indexed cache > is writing to the defaults table (which is very naughty and i keep > thinking about deleting it as a result). This patch makes reg_defaults const in the reg_config struct not in the regmap struct. Since we duplicate the reg_config reg_defaults into the regmap reg_defaults the index cache works on a runtime allocated array. (Though I wouldn't object to see it gone. For the average uscase it uses more memory and is slower than the rbnode cache). - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
