Re: [PATCH] IIO: Documentation: iio_utils: fix mask generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/24/11 12:41, michael.hennerich@xxxxxxxxxx wrote:
> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> 
> Variable sizeint is used uninitialized.
> Remove sizeint completely and use bits_used instead.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
Acked-by: Jonathan Cameron <jic23@xxxxxxxxx>

I clearly need to be more thorough in checking my demo apps code...

oops.
> ---
>  drivers/staging/iio/Documentation/iio_utils.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/Documentation/iio_utils.h b/drivers/staging/iio/Documentation/iio_utils.h
> index bde2313..1b33c04 100644
> --- a/drivers/staging/iio/Documentation/iio_utils.h
> +++ b/drivers/staging/iio/Documentation/iio_utils.h
> @@ -113,7 +113,7 @@ inline int iioutils_get_type(unsigned *is_signed,
>  	DIR *dp;
>  	char *scan_el_dir, *builtname, *builtname_generic, *filename = 0;
>  	char signchar;
> -	unsigned sizeint, padint;
> +	unsigned padint;
>  	const struct dirent *ent;
>  
>  	ret = asprintf(&scan_el_dir, FORMAT_SCAN_ELEMENTS_DIR, device_dir);
> @@ -159,7 +159,7 @@ inline int iioutils_get_type(unsigned *is_signed,
>  			fscanf(sysfsfp,
>  			       "%c%u/%u", &signchar, bits_used, &padint);
>  			*bytes = padint / 8;
> -			if (sizeint == 64)
> +			if (*bits_used == 64)
>  				*mask = ~0;
>  			else
>  				*mask = (1 << *bits_used) - 1;

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux