On 01/18/11 06:59, shubhrajyoti@xxxxxx wrote: > From: Shubhrajyoti Datta <shubhrajyoti@xxxxxx> > > Free the memory that is used only at init hmc5843_init_client is only called by probe. Could also be marked as devinit for consistency and possible tiny saving in memory... Otherwise all fine with me, please forward to GregKH. > > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti@xxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > --- > drivers/staging/iio/magnetometer/hmc5843.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c > index b1c26d8..9df66cd 100644 > --- a/drivers/staging/iio/magnetometer/hmc5843.c > +++ b/drivers/staging/iio/magnetometer/hmc5843.c > @@ -529,7 +529,7 @@ static void hmc5843_init_client(struct i2c_client *client) > pr_info("HMC5843 initialized\n"); > } > > -static int hmc5843_probe(struct i2c_client *client, > +static int __devinit hmc5843_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > struct hmc5843_data *data; > @@ -574,7 +574,7 @@ exit: > return err; > } > > -static int hmc5843_remove(struct i2c_client *client) > +static int __devexit hmc5843_remove(struct i2c_client *client) > { > struct hmc5843_data *data = i2c_get_clientdata(client); > /* sleep mode to save power */ > @@ -616,7 +616,7 @@ static struct i2c_driver hmc5843_driver = { > }, > .id_table = hmc5843_id, > .probe = hmc5843_probe, > - .remove = hmc5843_remove, > + .remove = __devexit_p(hmc5843_remove), > .detect = hmc5843_detect, > .address_list = normal_i2c, > }; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html