On 12.01.2011 12:31, Jonathan Cameron wrote:
On 01/12/11 09:55, Manuel Stahl wrote:
The normal behaviour is:
* After all transfers except the last: CS stays active
* After the last transfer: CS goes inactive
Hi Manuel,
Thanks for doing this.
This ideally wants an ack from someone at Analog (Michael perhaps?)
given it touches so many of their drivers.
I'm not keen on the level of change in the lis3l02dq going in within
this set. The change looks worthwhile, but it isn't just fixing
the cs_change problem so it really shouldn't be in this patch.
We can put that one in place at a later date.
Same is true for the sca3000 driver. Please just do the cs_change
fixes in this patch.
The functions I call do the same as the code that was there before but
without the cs_change. But I can understand your concern.
A few cases here remove cases where cs_change is set to 0 anyway.
Worthy cleanups, but not fixes. Still those are at least within
the spirit of the fixes and don't really matter.
Feel free to add my ack to a version with the lis3l02dq and sca3000
cleanups removed (and appropriate cs_change patches for those two).
Let's see what the analog guy say, then I'll prepare an update.
Regards,
Manuel Stahl
begin:vcard
fn:Manuel Stahl
n:Stahl;Manuel
email;internet:manuel.stahl@xxxxxxxxxxxxxxxxx
tel;work:+49 911 58061-6419
x-mozilla-html:FALSE
version:2.1
end:vcard
