Re: [PATCH 6/6] staging:iio:imu remove unecessary empty defs for event attributes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Does this patch work in the newest tree? In our current tree, it will
cause kernel panic in iio_register_interrupt_line() due to NULL
pointer.
-barry

On Thu, May 6, 2010 at 6:25 AM, Jonathan Cameron <jic23@xxxxxxxxx> wrote:
>
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>
> ---
>  drivers/staging/iio/imu/adis16300_core.c |   10 ----------
>  drivers/staging/iio/imu/adis16400_core.c |   10 ----------
>  2 files changed, 0 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/iio/imu/adis16300_core.c b/drivers/staging/iio/imu/adis16300_core.c
> index 5a7e5ef..54e3e51 100644
> --- a/drivers/staging/iio/imu/adis16300_core.c
> +++ b/drivers/staging/iio/imu/adis16300_core.c
> @@ -566,14 +566,6 @@ static IIO_CONST_ATTR_AVAIL_SAMP_FREQ("409 546 819 1638");
>
>  static IIO_CONST_ATTR(name, "adis16300");
>
> -static struct attribute *adis16300_event_attributes[] = {
> -       NULL
> -};
> -
> -static struct attribute_group adis16300_event_attribute_group = {
> -       .attrs = adis16300_event_attributes,
> -};
> -
>  static struct attribute *adis16300_attributes[] = {
>        &iio_dev_attr_accel_x_offset.dev_attr.attr,
>        &iio_dev_attr_accel_y_offset.dev_attr.attr,
> @@ -637,8 +629,6 @@ static int __devinit adis16300_probe(struct spi_device *spi)
>        }
>
>        st->indio_dev->dev.parent = &spi->dev;
> -       st->indio_dev->num_interrupt_lines = 1;
> -       st->indio_dev->event_attrs = &adis16300_event_attribute_group;
>        st->indio_dev->attrs = &adis16300_attribute_group;
>        st->indio_dev->dev_data = (void *)(st);
>        st->indio_dev->driver_module = THIS_MODULE;
> diff --git a/drivers/staging/iio/imu/adis16400_core.c b/drivers/staging/iio/imu/adis16400_core.c
> index 2c10072..34c0ee5 100644
> --- a/drivers/staging/iio/imu/adis16400_core.c
> +++ b/drivers/staging/iio/imu/adis16400_core.c
> @@ -595,14 +595,6 @@ static IIO_CONST_ATTR_AVAIL_SAMP_FREQ("409 546 819 1638");
>
>  static IIO_CONST_ATTR(name, "adis16400");
>
> -static struct attribute *adis16400_event_attributes[] = {
> -       NULL
> -};
> -
> -static struct attribute_group adis16400_event_attribute_group = {
> -       .attrs = adis16400_event_attributes,
> -};
> -
>  static struct attribute *adis16400_attributes[] = {
>        &iio_dev_attr_accel_x_offset.dev_attr.attr,
>        &iio_dev_attr_accel_y_offset.dev_attr.attr,
> @@ -669,8 +661,6 @@ static int __devinit adis16400_probe(struct spi_device *spi)
>        }
>
>        st->indio_dev->dev.parent = &spi->dev;
> -       st->indio_dev->num_interrupt_lines = 1;
> -       st->indio_dev->event_attrs = &adis16400_event_attribute_group;
>        st->indio_dev->attrs = &adis16400_attribute_group;
>        st->indio_dev->dev_data = (void *)(st);
>        st->indio_dev->driver_module = THIS_MODULE;
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux