On 06/01/2025 08:55, Christoph Hellwig wrote:
bool tag_alloc_policy_rr : 1;
Is it proper to use bool here? I am not sure. Others use unsigned int or
unsigned.
Yes, you can use any unsigned type for a single-bit bitfield. Most of
the existing uses just predate the availability of bool or were copy
and pasted after that.
nit: coding style elsewhere in scsi_host_template would be to use
"tag_alloc_policy_rr:1;"
Yes, but that's against the normal kernel coding style, so we'd better
stop adding more of that.
I suppose then that the rest should be updated afterwards to be
consistent (with the kernel coding style). That should be easier than -
for example - removing extern usage.
