On 04.11.2024 09:30, Niklas Cassel wrote: > On Fri, Nov 01, 2024 at 11:38:53PM +0100, Heiner Kallweit wrote: >> pci_intx() should be called by PCI core and some virtualization code >> only. In PCI device drivers use the appropriate pci_alloc_irq_vectors() >> call. > > Hello Heiner, > > as you might or might not know, this patch conflicts with a Philipp's > already acked patch: > https://lore.kernel.org/linux-ide/20241015185124.64726-10-pstanner@xxxxxxxxxx/ > I know, therefore he's on cc. Fully migrating PCI device drivers to the pci_alloc_irq_vectors() should be done anyway and is the cleaner alternative to changing pci_intx(). However for some drivers this is a rather complex task, therefore I understand Philipp's approach to adjust pci_intx() first. He's incorporating other review feedback in his series, so with the next re-spin he could remove the ahci patch from his series. > > Kind regards, > Niklas Heiner
