On 10/21/24 3:48 AM, Damien Le Moal wrote: > On 10/21/24 01:49, Sergey Shtylyov wrote: >> Before the dedicated Toshiba Piccolo driver was written by Alan Cox, >> these chips were handled by the generic driver; in case the dedicated >> driver isn't enabled, the generic driver keeps claiming these chips -- >> add a comment clarifying that... > > Nice. But this really does not need to be a separate patch. It does. I don't want to break the basic rule "do one thing per patch". > Please squash 1/2 and 2/2 together. Sorry, I'm not going to re-spin this once more. Besides, I've forewarned you that the comment will be added in a separate patch, and you didn't protest: https://lore.kernel.org/all/09af52c9-542f-b920-6ff1-e0b624300947@xxxxxx/ >> Suggested-by: Damien Le Moal <dlemoal@xxxxxxxxxx> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> [...] MBR, Sergey
