On 10/21/24 01:49, Sergey Shtylyov wrote:
> Before the dedicated Toshiba Piccolo driver was written by Alan Cox,
> these chips were handled by the generic driver; in case the dedicated
> driver isn't enabled, the generic driver keeps claiming these chips --
> add a comment clarifying that...
Nice. But this really does not need to be a separate patch. Please squash 1/2
and 2/2 together.
>
> Suggested-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> ---
> Changes in version 2:
> - new patch.
>
> drivers/ata/ata_generic.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ata/ata_generic.c b/drivers/ata/ata_generic.c
> index 2f57ec00ab82..d6c210510c36 100644
> --- a/drivers/ata/ata_generic.c
> +++ b/drivers/ata/ata_generic.c
> @@ -220,6 +220,11 @@ static struct pci_device_id ata_generic[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_OPTI, PCI_DEVICE_ID_OPTI_82C558), },
> { PCI_DEVICE(PCI_VENDOR_ID_CENATEK,PCI_DEVICE_ID_CENATEK_IDE),
> .driver_data = ATA_GEN_FORCE_DMA },
> + /*
> + * Before the dedicated Toshiba Piccolo driver was written,
> + * these chips were handled by the generic driver; keep the
> + * old behavior if the dedicated driver is not enabled...
> + */
> #if !defined(CONFIG_PATA_TOSHIBA) && !defined(CONFIG_PATA_TOSHIBA_MODULE)
> { PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA,PCI_DEVICE_ID_TOSHIBA_PICCOLO_1), },
> { PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA,PCI_DEVICE_ID_TOSHIBA_PICCOLO_2), },
--
Damien Le Moal
Western Digital Research
