On Fri, Jul 26, 2024 at 12:19:50PM +0900, Damien Le Moal wrote:
> Rename the array sil_blacklist to sil_quirks as this name is more
> neutral and is also consistent with how this driver define quirks with
> the SIL_QUIRK_XXX flags.
>
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> ---
> drivers/ata/sata_sil.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
> index 354b68ef91bc..3a99f66198a9 100644
> --- a/drivers/ata/sata_sil.c
> +++ b/drivers/ata/sata_sil.c
> @@ -128,7 +128,7 @@ static const struct pci_device_id sil_pci_tbl[] = {
> static const struct sil_drivelist {
> const char *product;
> unsigned int quirk;
> -} sil_blacklist [] = {
> +} sil_quirks[] = {
> { "ST320012AS", SIL_QUIRK_MOD15WRITE },
> { "ST330013AS", SIL_QUIRK_MOD15WRITE },
> { "ST340017AS", SIL_QUIRK_MOD15WRITE },
> @@ -600,8 +600,8 @@ static void sil_thaw(struct ata_port *ap)
> * list, and apply the fixups to only the specific
> * devices/hosts/firmwares that need it.
> *
> - * 20040111 - Seagate drives affected by the Mod15Write bug are blacklisted
> - * The Maxtor quirk is in the blacklist, but I'm keeping the original
> + * 20040111 - Seagate drives affected by the Mod15Write bug are quirked
> + * The Maxtor quirk is in sil_quirks, but I'm keeping the original
> * pessimistic fix for the following reasons...
> * - There seems to be less info on it, only one device gleaned off the
> * Windows driver, maybe only one is affected. More info would be greatly
> @@ -620,9 +620,9 @@ static void sil_dev_config(struct ata_device *dev)
>
> ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num));
>
> - for (n = 0; sil_blacklist[n].product; n++)
> - if (!strcmp(sil_blacklist[n].product, model_num)) {
> - quirks = sil_blacklist[n].quirk;
> + for (n = 0; sil_quirks[n].product; n++)
> + if (!strcmp(sil_quirks[n].product, model_num)) {
> + quirks = sil_quirks[n].quirk;
> break;
> }
>
> --
> 2.45.2
>
Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
