On Thu, Jun 13, 2024 at 03:13:54PM +0200, Niklas Cassel wrote:
> On Thu, Jun 13, 2024 at 05:29:31PM +0900, Damien Le Moal wrote:
> > On 6/13/24 15:34, Thomas Weißschuh wrote:
> I suggest that we:
> 1) Merge Damien's fix.
This might of course result in us getting other bug reports about their
distro no longer automounting their eSATA devices... and they might
consider that a user space regression as well.
(Since that behavior has now been there since 8a3e33cf92c7 ("ata: ahci:
find eSATA ports and flag them as removable"), which was merged in 2015.)
However, considering that the definition of the RMB bit has recently
(2020) been clarified, it is quite clear that we are currently violating
the spec, so I do still think that setting the RMB bit according to spec
is the right thing to do.
> 2) Modify SCSI to call dev_set_removable() and modify ata_scsiop_inq_std()
> to set the "HOT PLUGGABLE" field.
Kind regards,
Niklas
