Damien Le Moal <dlemoal@xxxxxxxxxx> writes: > We never add dead code. And code under a "#if 0" is by design dead... > So please do not do that. I left it that way temporarily so you could switch it to an #if 1 if you wanted to test it with your army of drives to see if any of them don't like it, and to see where I was proposing a runtime selection knob to switch which branch the code would take there. Would you be OK with leaving the PuiS -> SLEEP transition code in, but disabled by default? Then people who know their drives are OK with it can choose to enable it.
