The first 7 patch of this series fix several issues with suspend/resume power management operations in libata. The most important change introduced is in patch 4, where the manage_start_stop of scsi devices associated with ata devices is disabled and this functionality replaced by a direct handling within libata EH of device suspend/resume (i.e. spin down for suspend and spin up for resume). The remaining patches are code cleanup that do not introduce any significant functional change. This series was tested on qemu and on various PCs and servers. I am CC-ing people who recently reported issues with suspend/resume. Additional testing would be much appreciated. Of note is that there is no change to the overall suspend/resume model of libata where suspend and resume operations are tied to the ata port. This is somewhat broken as a port may have multiple devices (e.g. pata and port multiplier cases). Fixing this model (to be more similar to what libsas does) will be the next step. Changes from v1: * Added patch 8 and 9 to fix compilation warnings with W=1 * Addressed John comment in patch 19 * Fixed patch 20 commit message (Sergei) * Added Hannes Review tag Damien Le Moal (21): ata: libata-core: Fix ata_port_request_pm() locking ata: libata-core: Fix port and device removal ata: libata-scsi: link ata port and scsi device ata: libata-scsi: Disable scsi device manage_start_stop ata: libata-scsi: Fix delayed scsi_rescan_device() execution ata: libata-core: Do not register PM operations for SAS ports scsi: sd: Do not issue commands to suspended disks on remove ata: libata-core: Fix compilation warning in ata_dev_config_ncq() ata: libata-eh: Fix compilation warning in ata_eh_link_report() scsi: Remove scsi device no_start_on_resume flag ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() ata: libata-core: Synchronize ata_port_detach() with hotplug ata: libata-core: Detach a port devices on shutdown ata: libata-core: Remove ata_port_suspend_async() ata: libata-core: Remove ata_port_resume_async() ata: libata-core: skip poweroff for devices that are runtime suspended ata: libata-core: Do not resume ports that have been runtime suspended ata: libata-sata: Improve ata_sas_slave_configure() ata: libata-eh: Improve reset error messages ata: libata-eh: Reduce "disable device" message verbosity ata: libata: Cleanup inline DMA helper functions drivers/ata/libata-core.c | 241 +++++++++++++++++++++++++-------- drivers/ata/libata-eh.c | 76 +++++++++-- drivers/ata/libata-sata.c | 5 +- drivers/ata/libata-scsi.c | 143 ++++++++++--------- drivers/ata/libata-transport.c | 9 +- drivers/ata/libata.h | 7 + drivers/ata/pata_macio.c | 1 + drivers/ata/sata_mv.c | 1 + drivers/ata/sata_nv.c | 2 + drivers/ata/sata_sil24.c | 1 + drivers/scsi/scsi_scan.c | 12 +- drivers/scsi/sd.c | 10 +- include/linux/libata.h | 27 ++-- include/scsi/scsi_device.h | 1 - include/scsi/scsi_host.h | 2 +- 15 files changed, 372 insertions(+), 166 deletions(-) -- 2.41.0
