On Wed, Aug 23, 2023 at 11:10 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Aug 23, 2023 at 12:14 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
> > Some users of pata_falcon on Q40 have IDE disks in default
> > IDE little endian byte order, whereas legacy disks use
> > host-native big-endian byte order as on the Atari Falcon.
> >
> > Add module parameter 'data_swab' to allow connecting drives
> > with non-native data byte order. Drives selected by the
> > data_swap bit mask will have their user data byte-swapped to
> > host byte order, i.e. 'pata_falcon.data_swab=2' will byte-swap
> > all user data on drive B, leaving data on drive A in native
> > byte order. On Q40, drives on a second IDE interface may be
> > added to the bit mask as bits 2 and 3.
> >
> > Default setting is no byte swapping, i.e. compatibility with
> > the native Falcon or Q40 operating system disk format.
> >
> > Cc: William R Sowerbutts <will@xxxxxxxxxxxxxx>
> > Cc: Finn Thain <fthain@xxxxxxxxxxxxxx>
> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Tested-by: William R Sowerbutts <will@xxxxxxxxxxxxxx>
> > Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
> >
> > ---
> >
> > Changes since v2:
> >
> > Geert Uytterhoeven:
> > - only shift swap bitmask if pdev->id > 0
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Oops, I meant
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
But it never hurts to have more review tags ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
