Hi Geert,
Am 19.08.2023 um 02:44 schrieb Geert Uytterhoeven:
Hi Michael,
On Fri, Aug 18, 2023 at 9:14 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
The pata_falcon data byte swapping patch relies on pdev->id
being 0 or 1. Q40 uses these IDs, but Atari used -1. Change
pdev->id to 0 for Atari Falcon IDE platform device so
selection of drive to byte-swap through pata_falcon.data_swab
can be used on Falcon as well.
Tested on ARAnyM so far.
Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
Iff this patch is accepted, it must go in before [PATCH v2 2/3], else
the latter would cause a regression. And backporting to stable must
take that into account, too.
I don't see it as a regression - the driver still works OK, it's only
the byte swap option that's broken on Atari, and that's newly introduced.
But this patch changes the user space exposed platform device name, as
you point out elsewhere. That's reason enough to drop it.
Alternative, only consider pdev->id if it's positive?
Only shift by two bits if pdev->id is > 0? (some consider 0 positive...)
I'll rewrite that bit and respin.
Cheers,
Michael
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
