Re: [PATCH v2 3/3] m68k/atari: change Falcon IDE platform device to id 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Fri, Aug 18, 2023 at 9:14 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
> The pata_falcon data byte swapping patch relies on pdev->id
> being 0 or 1. Q40 uses these IDs, but Atari used -1. Change
> pdev->id to 0 for Atari Falcon IDE platform device so
> selection of drive to byte-swap through pata_falcon.data_swab
> can be used on Falcon as well.
> Tested on ARAnyM so far.
>
> Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>

Iff this patch is accepted, it must go in before [PATCH v2 2/3], else
the latter would cause a regression. And backporting to stable must
take that into account, too.

Alternative, only consider pdev->id if it's positive?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux