On 4/12/23 13:43, Christoph Hellwig wrote: > On Wed, Apr 12, 2023 at 09:59:30AM +0900, Damien Le Moal wrote: >> Good point. If we move the code for cdl_enable to libata, then we will not be >> covering the SAS HBA cases. >> >> Christoph, >> >> I do not see a cleaner solution... Can we keep this patch as is ? Any other idea ? > > I guess we have to. But it's really ugly and someone in T13 really needs > to be slapped.. It is T10 rather than T13 that screwed up: if SPC also defined a CDL feature on/off through mode sense/select, we would not need any "if (is_ata)"... For ATA/T13, the on/off makes sense because of the mutual exclusion with NCQ priority.
