Re: [PATCH v6 09/19] scsi: allow enabling and disabling command duration limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/11/23 15:16, Christoph Hellwig wrote:
> On Thu, Apr 06, 2023 at 01:32:38PM +0200, Niklas Cassel wrote:
>> +	/*
>> +	 * For ATA devices, CDL needs to be enabled with a SET FEATURES command.
>> +	 */
>> +	if (is_ata) {
> 
> I don't think these hacks have any business in the SCSI layer.  We should
> probbaly just do this unconditionally for CDL enabled ATA devices at
> probe time.

Yes, this is not pretty, but this has the advantage of not requiring a lot of
special code for ata, especially the sysfs attribute does not have to be defined
in both scsi and ata.

But yes, I guess we could just unconditionally enable CDL for ATA on device scan
to be on par with scsi, which has CDL always enabled.



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux