On 2/11/23 5:42 PM, Ondrej Zary wrote:
> Only bpck driver uses devtype but it never gets set in pata_parport.
> Remove it.
>
> Signed-off-by: Ondrej Zary <linux@xxxxxxx>
> ---
> drivers/ata/pata_parport/bpck.c | 2 +-
> include/linux/pata_parport.h | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> index b9174cf8863c..451a068fe28a 100644
> --- a/drivers/ata/pata_parport/bpck.c
> +++ b/drivers/ata/pata_parport/bpck.c
> @@ -241,7 +241,7 @@ static void bpck_connect ( PIA *pi )
>
> WR(5,8);
>
> - if (pi->devtype == PI_PCD) {
> + if (1 /*pi->devtype == PI_PCD*/) { /* FIXME */
> WR(0x46,0x10); /* fiddle with ESS logic ??? */
Why not drop this entire *if* stmt?
> WR(0x4c,0x38);
> WR(0x4d,0x88);
[...]
MBR, Sergey
