On 2022/09/08 22:02, James Bottomley wrote: > On Thu, 2022-09-08 at 12:56 +0000, Conor.Dooley@xxxxxxxxxxxxx wrote: >> On 08/09/2022 13:49, wangjianli wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you >>> know the content is safe >>> >>> Delete the redundant word 'in'. >>> >>> Signed-off-by: wangjianli <wangjianli@xxxxxxxxxx> >>> --- >>> drivers/ata/libata-eh.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c >>> index 7c128c89b454..ca865a95cf24 100644 >>> --- a/drivers/ata/libata-eh.c >>> +++ b/drivers/ata/libata-eh.c >>> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list >>> *t) >>> * >>> * Set ATA_PFLAG_EH_PENDING and activate fast drain if >>> @fastdrain >>> * is non-zero and EH wasn't pending before. Fast drain >>> ensures >>> - * that EH kicks in in timely manner. >>> + * that EH kicks in timely manner. >> >> Hey wangjianli, >> This does not look like the right fix to me.. To me, it looks like it >> should be s/in in/in in a/. >> >> If you're using an automated tool, which I can only assume you are, >> to find these typos it'd be a good idea to check the output for >> correctness prior to sending patches. > > And it would also have been nice to accommodate the exact same feedback > last time these patches were posted: > > https://lore.kernel.org/all/cec12e246d7151f6041bf553629a3047e81d4afe.camel@xxxxxxxxxxxxxxxxxxxxx/ > > It's really disappointing you haven't accommodated any feedback either > into your bot or the patches it sends. Not doing so really does render > this work largely useless. And another submitter sent a similar incorrect "fix", twice, ignoring my comments. I am OK with applying such fixes, even though they have little value. But the submitter has to be willing to listen and fix their patches. I will not do that for them :) -- Damien Le Moal Western Digital Research
