On Thu, Sep 1, 2022 at 12:55 AM Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> wrote: > As for the stat_table, except for the first buggy entry as mentioned > above, I have no clue where these come from. SAT only defines the HARDWARE > ERROR / INTERNAL TARGET FAILURE for when the status field device fault bit > is set. Need to dig further, but I am afraid this code may be due to years > of supporting drives returning weird errors that got mapped to sensible > sense codes instead of a pure implementation of the specs... That last sentence is probably the key to a lot of this, in which case one would wish for a comment or two as to why. I was trying to do some more digging in the git history, but it seems that interesting bits predate the 2005 git import date of the kernel sources and I am not sure how to look further back. Also it might be that by now "consumers" of these error codes may require them to stay the way they are, i.e. even if something turns out to be "wrong" it might be "unfixable" to not break userland? > I need to spend some quality time with ACS and SAT documents to sort out > this one... And lots of coffee too probably :) I am starting to feel bad for kicking a hornet's nest in the shape of a tiny function. :-D Thank you so much, both of you, for spending time on this. Cheers, Peter
