On 7/31/22 03:14, Tomas Henzl wrote: > Specifying timeout value may help in troubleshooting failures. s/Specify/Print the And in the patch title too. I.e.: ata: libata: Print timeout value when internal command times out No period at the end of the patch title. And please use get_maintainer.pl: ata patches should be addressed to me too otherwise, there's a high chance they will be ignored. > > Signed-off-by: David Milburn <dmilburn@xxxxxxxxxx> > Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx> > --- > > V2: timeout changed to unsigned int as in for-next > > drivers/ata/libata-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 826d41f341e4..0fc4782ef4f8 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -1578,8 +1578,8 @@ static unsigned ata_exec_internal_sg(struct ata_device *dev, > else > ata_qc_complete(qc); > > - ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n", > - command); > + ata_dev_warn(dev, "qc timeout after %u msecs (cmd 0x%x)\n", > + timeout, command); > } > > spin_unlock_irqrestore(ap->lock, flags); > -- Damien Le Moal Western Digital Research
