Re: [PATCH] ata: sata_mv: Fixes expected number of resources now IRQs are gone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/1/22 05:49, Andrew Lunn wrote:
> The commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ
> resource from DT core") stopped IRQ resources being available as
> platform resources. This broke the sanity check for the expected
> number of resources in the Marvell SATA driver which expected two
> resources, the IO memory and the interrupt.
> 
> Change the sanity check to only expect the IO memory.
> 
> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> ---
> 
> v5.19-rc8 is broken. I guess there will not be a -rc9, so please could you
> queue this up for 5.19.1.

I will queue this for 5.10-rc1 and this will be picked up automatically
for stable 5.19.x thanks to the Fixes tag.

> 
> drivers/ata/sata_mv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index de5bd02cad44..e3cff01201b8 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4057,7 +4057,7 @@ static int mv_platform_probe(struct platform_device *pdev)
>  	/*
>  	 * Simple resource validation ..
>  	 */
> -	if (unlikely(pdev->num_resources != 2)) {
> +	if (unlikely(pdev->num_resources != 1)) {
>  		dev_err(&pdev->dev, "invalid number of resources\n");
>  		return -EINVAL;
>  	}


-- 
Damien Le Moal
Western Digital Research



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux