On 4/7/22 3:37 PM, Damien Le Moal wrote:
> To facilitate debugging of drive issues in the field without kernel
> changes (e.g. temporary test patches), add an entry for most horkage
> flags in the force_tbl array to allow controlling these horkage
> settings with the libata.force kernel boot parameter.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/ata/libata-core.c | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 75856f4210d7..121cb55a219a 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6230,9 +6230,27 @@ static const struct ata_force_param force_tbl[] __initconst = {
> force_horkage_onoff(ncqtrim, ATA_HORKAGE_NO_NCQ_TRIM),
> force_horkage_onoff(ncqati, ATA_HORKAGE_NO_NCQ_ON_ATI),
>
> - force_horkage_on(dump_id, ATA_HORKAGE_DUMP_ID),
> + force_horkage_onoff(trim, ATA_HORKAGE_NOTRIM),
> + force_horkage_onoff(trim_zero, ATA_HORKAGE_ZERO_AFTER_TRIM),
> + force_horkage_on(max_trim_128m, ATA_HORKAGE_MAX_TRIM_128M),
> +
> + force_horkage_onoff(dma, ATA_HORKAGE_NODMA),
> force_horkage_on(atapi_dmadir, ATA_HORKAGE_ATAPI_DMADIR),
> - force_horkage_on(disable, ATA_HORKAGE_DISABLE)
> + force_horkage_on(atapi_mod16_dma, ATA_HORKAGE_ATAPI_MOD16_DMA),
> +
> + force_horkage_onoff(dma_log, ATA_HORKAGE_NO_DMA_LOG),
> + force_horkage_onoff(id_dev_log, ATA_HORKAGE_NO_ID_DEV_LOG),
> + force_horkage_onoff(log_dir, ATA_HORKAGE_NO_LOG_DIR),
Underscores in the names with "no" (without underscore) would look inconsistent,
wouldn't they? Maybe drop the underscores here?
[...]
Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
MBR, Sergey
