Re: [PATCH 3/5] ata: libata-core: Improve link flags forced settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/7/22 3:37 PM, Damien Le Moal wrote:

> Similarly to the horkage flags, introduce the force_lflag_onoff() macro
> to define struct ata_force_param entries of the force_tbl array that
> allow turning on or off a link flag using the libata.force boot
> parameter. Using this new helper macro, define a new force_tbl entry
> for the ATA_LFLAG_NO_DEBOUNCE_DELAY link flag, thus allowing testing if
> an adapter requires a link debounce delay or not.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/ata/libata-core.c | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index c0cf42ffcc38..75856f4210d7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
[...]
> @@ -6154,7 +6161,11 @@ EXPORT_SYMBOL_GPL(ata_platform_remove_one);
>  	{ # mode,	.xfer_mask	= (1UL << (shift)) }
>  
>  #define force_lflag_on(name, flags)			\
> -	{ # name,	.lflags		= (flags) }
> +	{ # name,	.lflags_on	= (flags) }

   The same comment about #name...

> +
> +#define force_lflag_onoff(name, flags)			\
> +	{ "no" # name,	.lflags_on	= (flags) },	\
> +	{ # name,	.lflags_off	= (flags) }
>  
>  #define force_horkage_on(name, flag)			\
>  	{ # name,	.horkage_on	= (flag) }
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux