Hi > Gesendet: Samstag, 05. März 2022 um 00:37 Uhr > Von: "Rob Herring" <robh@xxxxxxxxxx> > > > > + ports-implemented: > > > > + $ref: '/schemas/types.yaml#/definitions/uint32' > > > > + description: > > > > + Mask that indicates which ports that the HBA supports > > > > + are available for software to use. Useful if PORTS_IMPL > > > > + is not programmed by the BIOS, which is true with > > > > + some embedded SoCs. > > > > + maxItems: 1 > > > > > > A uint32 is only ever 1 item. Drop. > > > > > > IIRC, isn't the max here 0xff? Add constraints. > > > > i've found it only set to 0x1 so i have currently set the maximum to 0x1, is this ok? > > If some higher value is needed binding needs to be touched... > > There's a spec for it, so no need to look at what's used. Calxeda AHCI > had 5 ports IIRC. as far as i understand code in libahci.c line 535+ [1] i guess i need to set lower 5 bits to 1 for 5 ports, right? resulting in max value 0x1f > > now i have only the marvell-errors about incomplete sata-port subnode (without phy/target-supply) like i mention in the patch...how to proceed with this? > > So the child nodes are incomplete? They should be disabled then > (status = "disabled") and that turns off required properties checks. thanks, have disable the nodes and reenable them where phys/target-supply was added [2]... now the dtbs_check is clean [1] https://elixir.bootlin.com/linux/v5.17-rc6/source/drivers/ata/libahci.c#L535 [2] https://github.com/frank-w/BPI-R2-4.14/commits/5.17-next-20220225 regards Frank
