On 2/22/22 18:48, Sergey Shtylyov wrote: > On 2/22/22 3:37 AM, Damien Le Moal wrote: > >>> HPT371 chips physically have only one channel, the secondary one, however >>> the primary channel registers do exist! Thus we have to manually disable >>> the non-existing channel (if the BIOS hasn't done this already). Alan Cox >>> has only added such code to the 'pata_hpt3x2n' driver, forgetting about >>> this one... :-/ >> >> No need to assign blame by name :) Something more neutral like: >> >> "Similarly to the pata_hpt3x2n driver, always disable the primary channel." > > Should I now repost? I will fix it up. No need to resend. > >> will do. Also, do you have a fixes tag for this one ? Is it again: >> >> Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers.")> ? > > Yes. > >>> >>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > [...] > > MBR, Sergey -- Damien Le Moal Western Digital Research