On 2/18/22 20:17, Sergey Shtylyov wrote:
> On 2/18/22 2:05 PM, Sergey Shtylyov wrote:
>
>> Due to my sloppy coding in commit 2c75a451ecb0 ("ata: libata-sff: refactor
>> ata_sff_altstatus()"), in ata_sff_lost_interrupt() iff the device control
>> register doesn't exists, ata_port_warn() would print the 'status' variable
>> which never gets assigned. Restore the original order of the statements,
>> wrapping the ata_sff_altstatus() call in WARN_ON_ONCE()...
>>
>> While at it, fix crazy indentation in the ata_port_warn() call itself...
>>
>> Fixes: 2c75a451ecb0 ("ata: libata-sff: refactor ata_sff_altstatus()")
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>>
>> ---
>
> Forgot to mention that it's against the 'for-next' branch of 'libata.git'. :-/
No need to mention it, it always should be :)
>
> [...]
>
> MBR, Sergey
--
Damien Le Moal
Western Digital Research
