On 2/18/22 12:35 PM, Sergey Shtylyov wrote:
>>>>> After commit e0afcf140e6e ("ata: pata_hpt37x: disable fast interrupts in
>>>>> prereset() method") HPT370's and HPT372+'s PIO/DMA mode setting functions
>>>>> have become identical -- merge them.
>>>>>
>>>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>>>>>
>>>>> ---
>>>>> This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git'
>>>>> repo.
>>>>>
>>>>> drivers/ata/pata_hpt37x.c | 71 +++++++---------------------------------------
>>>>> 1 file changed, 11 insertions(+), 60 deletions(-)
>>>>>
>>>>> Index: libata/drivers/ata/pata_hpt37x.c
>>>>> ===================================================================
>>>>> --- libata.orig/drivers/ata/pata_hpt37x.c
>>>>> +++ libata/drivers/ata/pata_hpt37x.c
>>> [...]
>>>>> @@ -604,8 +556,7 @@ static struct ata_port_operations hpt370
>>>>> };
>>>>>
>>>>> /*
>>>>> - * Configuration for HPT371 and HPT302. Slightly different PIO and DMA
>>>>> - * mode setting functionality.
>>>>> + * Configuration for HPT371 and HPT302.
>>>>
>>>> Shouldn't this be HPT372 ?
>>>
>>> No, HPT372 ops are situated below -- they inherit from these.
>>
>> Yep. Got it (checked the code :)). All good.
>
> Not all good, unfortunately. :-/
> Building with C=1 has shown:
Actually, even with W=1...
> drivers/ata/pata_hpt37x.c:453: warning: expecting prototype for hpt370_set_piomode(). Prototype was for hpt37x_set_piomode() instead
> drivers/ata/pata_hpt37x.c:466: warning: expecting prototype for hpt370_set_dmamode(). Prototype was for hpt37x_set_dmamode() instead
>
> i.e. I forgot to update the kernel-doc comments... Let me respin it!
Resent now.
>>> [...]
MBR, Sergey
