On 2/17/22 18:49, Sergey Shtylyov wrote: > On 2/16/22 2:29 PM, Damien Le Moal wrote: > >>> After commit e0afcf140e6e ("ata: pata_hpt37x: disable fast interrupts in >>> prereset() method") HPT370's and HPT372+'s PIO/DMA mode setting functions >>> have become identical -- merge them. >>> >>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> >>> >>> --- >>> This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git' >>> repo. >>> >>> drivers/ata/pata_hpt37x.c | 71 +++++++--------------------------------------- >>> 1 file changed, 11 insertions(+), 60 deletions(-) >>> >>> Index: libata/drivers/ata/pata_hpt37x.c >>> =================================================================== >>> --- libata.orig/drivers/ata/pata_hpt37x.c >>> +++ libata/drivers/ata/pata_hpt37x.c > [...] >>> @@ -604,8 +556,7 @@ static struct ata_port_operations hpt370 >>> }; >>> >>> /* >>> - * Configuration for HPT371 and HPT302. Slightly different PIO and DMA >>> - * mode setting functionality. >>> + * Configuration for HPT371 and HPT302. >> >> Shouldn't this be HPT372 ? > > No, HPT372 ops are situated below -- they inherit from these. Yep. Got it (checked the code :)). All good. > > [...] > > MBR, Sergey -- Damien Le Moal Western Digital Research