On 1/4/22 20:35, Hannes Reinecke wrote:
> On 1/4/22 11:58 AM, Damien Le Moal wrote:
>> Add Kconfig dependendy on COMPILE_TEST to allow compile tests with
>> configs that do not have X86_32 enabled.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/ata/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index b706a3a64b11..daf57a4e8196 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -654,7 +654,7 @@ config PATA_CS5530
>>
>> config PATA_CS5535
>> tristate "CS5535 PATA support (Experimental)"
>> - depends on PCI && X86_32
>> + depends on PCI && (X86_32 || COMPILE_TEST)
>> help
>> This option enables support for the NatSemi/AMD CS5535
>> companion chip used with the Geode processor family.
>>
> Looks weird, but seems to be de rigeur in ata/Kconfig.
So it turns out that this one actually compile only with X86 32 and 64
because of the use of asm/msr.h functions.
So I changed it to:
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9d37485c638b..c432cf205589 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -637,7 +637,7 @@ config PATA_CS5530
config PATA_CS5535
tristate "CS5535 PATA support (Experimental)"
- depends on PCI && X86_32
+ depends on PCI && (X86_32 || (X86_64 && COMPILE_TEST))
help
This option enables support for the NatSemi/AMD CS5535
companion chip used with the Geode processor family.
I kept your reviewed-by tag. Please let me know if this is OK.
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
