On 1/12/21 2:15 PM, Sergei Shtylyov wrote: [...] >> From: Menglong Dong <dong.menglong@xxxxxxxxxx> >> >> Coccinelle reports a redundant error print in rb532_pata_driver_probe. >> As 'platform_get_irq' already prints the error message, error print >> here is redundant and can be removed. >> >> Signed-off-by: Menglong Dong <dong.menglong@xxxxxxxxxx> >> --- >> drivers/ata/pata_rb532_cf.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c >> index 479c4b29b856..dcde84f571c4 100644 >> --- a/drivers/ata/pata_rb532_cf.c >> +++ b/drivers/ata/pata_rb532_cf.c >> @@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "no IRQ resource found\n"); >> + if (irq <= 0) >> return -ENOENT; > > This still beaks the probe deferral. :-( > But that's another problem... BTW, your patch summary looks quite wrong -- we need the prefix to specify the patch locus, like this: pata_rb532_cf: remove redundant error printing in the probe() method I.e. "ata: " may even be omitted (your choise though). > [...] MBR, Sergei