Hello Tejun, Thank you very much for your reply. To answer your question: 1. Yes we will start working on a patch and send it for review. 2. We found this issue during our code review. Another information I need to bring to your attention is that many user libraries today decode the fixed format sense block based on the format today's kernel (ata_gen_passthru_sense) provides. Rather than the format specified in the SCSI Primary commands - 4 specification. If we were to correct the field offsets for the fixed format sense block. It may break such libraries. How do you assess the impact of such a change? Regards, Akshat On Mon, Aug 17, 2020 at 10:42 AM Tejun Heo <tj@xxxxxxxxxx> wrote: > > Hello, > > On Mon, Aug 03, 2020 at 09:44:26AM -0700, Akshat Jain wrote: > > Hello Jens Tejun, > > I have a question regarding the ata_gen_passthru_sense function (libata-scsi.c). > > > > This function while generating fixed format sense blocks, puts the > > INFORMATION field at offset 8 and COMMAND-SPECIFIC-INFORMATION at > > offset 16. > > While as per SCSI Primary commands - 4 specification, section 4.5.3 > > Fixed format sense data Table 53, the INFORMATION field is at offset 3 > > and COMMAND-SPECIFIC-INFORMATION is at offset 8. > > Sorry about the late reply. I could have been easily mistaken and don't > think the path has been under any kind of scrutiny. The best way to proceed > would be submitting a patch referencing the spec cc'ing linux-ide and > linux-scsi. Have you guys got bitten by this or is this discovered through > code review? > > Thanks. > > -- > tejun
