Hello, On Mon, Aug 03, 2020 at 09:44:26AM -0700, Akshat Jain wrote: > Hello Jens Tejun, > I have a question regarding the ata_gen_passthru_sense function (libata-scsi.c). > > This function while generating fixed format sense blocks, puts the > INFORMATION field at offset 8 and COMMAND-SPECIFIC-INFORMATION at > offset 16. > While as per SCSI Primary commands - 4 specification, section 4.5.3 > Fixed format sense data Table 53, the INFORMATION field is at offset 3 > and COMMAND-SPECIFIC-INFORMATION is at offset 8. Sorry about the late reply. I could have been easily mistaken and don't think the path has been under any kind of scrutiny. The best way to proceed would be submitting a patch referencing the spec cc'ing linux-ide and linux-scsi. Have you guys got bitten by this or is this discovered through code review? Thanks. -- tejun
