On 6/24/19 6:32 PM, Tejun Heo wrote: > ZAC support added sense data requesting on error for both ZAC and ATA > devices. This seems to cause erratic error handling behaviors on some > SSDs where the device reports sense data availability and then > delivers the wrong content making EH take the wrong actions. The > failure mode was sporadic on a LITE-ON ssd and couldn't be reliably > reproduced. > > There is no value in requesting sense data from non-ZAC ATA devices > while there's a significant risk of introducing EH misbehaviors which > are difficult to reproduce and fix. Let's do the sense data dancing > only for ZAC devices. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxxxx> > --- > drivers/ata/libata-eh.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Ah well. I hoped those bothering to implement sense data would do it properly; seems I've been mistaken. Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
