On Wed, May 23, 2018 at 08:13:56AM -0600, Jens Axboe wrote: > > Should I move to code to a new drivers/scsi/scsi_sense.c and add it to > > drivers/scsi/Makefile as: > > > > obj-$(CONFIG_BLK_SCSI_REQUEST) += scsi_sense.o > > > > Every place I want to use the code is already covered by > > CONFIG_BLK_SCSI_REQUEST, so it seems like I just need to know where to > > put the .c file. :P > > I think this is so much saner than a SCSI select or dependency, so I'll > have to disagree with Martin and Christoph. Just put it in drivers/scsi, > if it's the location they care about. I actually plan to remove CONFIG_BLK_SCSI_REQUEST in a merge window or two. The only users are scsi and the ide layer, (virtio_blk support has already been accidentally disabled for a while), and getting rid of it allows to to shrink and simply the scsi data structures. But if you want this for now lets keep scsi_sense.c in drivers/scsi but depend on CONFIG_BLK_SCSI_REQUEST, that is easy enough to fix up. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
