RE: [PATCH V6 7/7] ata: ahci_tegra: Add AHCI support for tegra210

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



okay

>-----Original Message-----
>From: Mikko Perttunen [mailto:cyndis@xxxxxxxx]
>Sent: Tuesday, January 23, 2018 9:26 PM
>To: Preetham Chandru <pchandru@xxxxxxxxxx>; thierry.reding@xxxxxxxxx;
>tj@xxxxxxxxxx
>Cc: preetham260@xxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; linux-
>ide@xxxxxxxxxxxxxxx; Venu Byravarasu <vbyravarasu@xxxxxxxxxx>; Pavan
>Kunapuli <pkunapuli@xxxxxxxxxx>
>Subject: Re: [PATCH V6 7/7] ata: ahci_tegra: Add AHCI support for tegra210
>
>Tegra210 should be capitalized in the subject, and a commit message is needed.
>
>   Add support for the AHCI-compliant Serial ATA host controller on the
>   Tegra210 system-on-chip.
>
>Otherwise,
>Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
>
>Mikko
>
>On 01/09/2018 09:17 AM, Preetham Chandru Ramchandra wrote:
>> From: Preetham Ramchandra <pchandru@xxxxxxxxxx>
>>
>> Signed-off-by: Preetham Chandru R <pchandru@xxxxxxxxxx>
>> ---
>>   drivers/ata/ahci_tegra.c | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index
>> 013880de6412..3f00dfa3760d 100644
>> --- a/drivers/ata/ahci_tegra.c
>> +++ b/drivers/ata/ahci_tegra.c
>> @@ -256,6 +256,10 @@ static const struct tegra_ahci_soc
>tegra124_ahci_soc_data = {
>>   	},
>>   };
>>
>> +static const struct tegra_ahci_soc tegra210_ahci_soc_data = {
>> +	.quirks = NO_DEVSLP,
>> +};
>> +
>
>Nit, I'd prefer this to be directly above the of_device_id table.
>
>>   static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
>>   {
>>   	struct tegra_ahci_priv *tegra = hpriv->plat_data; @@ -471,6 +475,10
>> @@ static const struct of_device_id tegra_ahci_of_match[] = {
>>   		.compatible = "nvidia,tegra124-ahci",
>>   		.data = &tegra124_ahci_soc_data
>>   	},
>> +	{
>> +		.compatible = "nvidia,tegra210-ahci",
>> +		.data = &tegra210_ahci_soc_data
>> +	},
>>   	{}
>>   };
>>   MODULE_DEVICE_TABLE(of, tegra_ahci_of_match); @@ -585,5 +593,5 @@
>> static struct platform_driver tegra_ahci_driver = {
>>   module_platform_driver(tegra_ahci_driver);
>>
>>   MODULE_AUTHOR("Mikko Perttunen <mperttunen@xxxxxxxxxx>");
>> -MODULE_DESCRIPTION("Tegra124 AHCI SATA driver");
>> +MODULE_DESCRIPTION("Tegra AHCI SATA driver");
>>   MODULE_LICENSE("GPL v2");
>>
��.n��������+%������w��{.n�����{��'^�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux