Hi, On Friday, June 30, 2017 07:26:31 PM Preetham Chandru Ramchandra wrote: > From: Preetham Chandru R <pchandru@xxxxxxxxxx> > > 1. Move tegra124 specifics to tegra124_ahci_init. > 2. Separate the regulators needed for tegra124 and tegra210. > 3. Disable DIPM for t210 and t124 as there are known issues. > 4. Disable Devslp for t210 since devslp pin is shared with > pcie clkreq. > > Signed-off-by: Preetham Chandru R <pchandru@xxxxxxxxxx> Please consider splitting this combined patch on smaller logical parts (adding new initialization code used on both chipsets to tegra_ahci_controller_init() should be done in preparatory patch before adding T210 support, same for addition of NO_DIPM flag) to ease the review, potential handling of regressions and backporting of fixes to older kernels. The code changes itself look good to me. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
