On 07/10/2017 07:45 AM, Damien Le Moal wrote: > The warning message "READ LOG DMA EXT failed, trying unqueued" in > ata_read_log_page() as well as the macro name ATA_HORKAGE_NO_NCQ_LOG > are confusing: the command READ LOG DMA EXT is not an queued NCQ command > unless it is encapsulated in a RECEIVE FPDMA QUEUED command. > From ACS-4 READ LOG DMA EXT description: > > "The device processes the READ LOG DMA EXT command in the NCQ feature > set environment (see 4.13.6) if the READ LOG DMA EXT command is > encapsulated in a RECEIVE FPDMA QUEUED command (see 7.30) with the > inputs encapsulated as shown in 7.23.6." > > To avoid confusion, fix the warning messsage to mention switching to PIO and > not "unqueued" and rename the macro ATA_HORKAGE_NO_NCQ_LOG to > ATA_HORKAGE_NO_DMA_LOG. > > Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx> > --- > drivers/ata/libata-eh.c | 6 +++--- > include/linux/libata.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > You are correct. Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
