Hi, On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote: > Hi, > > On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote: > > Add Palmchip BK3710 PATA controller driver. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > There are some checkpatch suggestions that are worth fixing, I think. > > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem" Will be fixed in v3, thanks. [ My scripts didn't run checkpatch with --strict so I haven't noticed them. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
