Hello. On 02/21/2017 05:22 PM, Luiz Carlos Ramos wrote:
Two messages are now displayed (at "warn" level) to make sure the user is aware that PCI IDE devices were detected at common addresses (0x1f0 and 0x170) and that they will not be managed by ide-generic, but rather delegated to its specific driver. Signed-off-by: Luiz Carlos Ramos <lramos.prof@xxxxxxxxxxxx> --- drivers/ide/ide-generic.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c index ee11edcdba3170c077381d603918498d79ffa3bb..2204819ef73612deed4ebfe58c69cdadb40fa53b 100644 --- a/drivers/ide/ide-generic.c +++ b/drivers/ide/ide-generic.c @@ -125,9 +125,19 @@ static int __init ide_generic_init(void) if (primary == 0) probe_mask |= 0x1; + else {
CodingStyle: need {} in both *if* branches if at least one branch has them.
+ printk(KERN_WARN DRV_NAME ": PCI IDE device detected at 0x%4.4x." + " ide-generic will not grab this device, delegating it to" + " the driver of its specific chipset\n", 0x1f0);
The messages shouldn't be split -- checkpatch.pl knows about that.
+ } if (secondary == 0) probe_mask |= 0x2; + else { + printk(KERN_WARN DRV_NAME ": PCI IDE device detected at 0x%4.4x." + " ide-generic will not grab this device, delegating it to" + " the driver of its specific chipset\n", 0x170); + }
Same here. [..] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html