2017-01-16 13:45 GMT+01:00 Sekhar Nori <nsekhar@xxxxxx>: > On Monday 16 January 2017 03:43 PM, Bartosz Golaszewski wrote: >> 2017-01-13 20:25 GMT+01:00 David Lechner <david@xxxxxxxxxxxxxx>: >>> >>> A clock multiplier property seems redundant if you are specifying a clock. >>> It should be possible to get the rate from the clock to determine which >>> multiplier is needed. >>> >> >> I probably should have named it differently. This is not a multiplier >> of a clock derived from PLL0 or PLL1. Instead it's a value set by >> writing to the Port PHY Control Register (MPY bits) of the SATA >> controller that configures the multiplier for the external low-jitter >> clock. On the lcdk the signals (REFCLKP, REFCLKN) are provided by >> CDCM61001 (SATA OSCILLATOR component on the schematics). >> >> I'll find a better name and comment the property accordingly. >> >> FYI: the da850 platform does not use the common clock framework, so I >> don't specify the clock property on the sata node in the device tree. >> Instead I add the clock lookup entry in patch [01/10]. This is >> transparent for AHCI which can get the clock as usual by calling >> clk_get() in ahci_platform_get_resources(). > > I think David's point is that the SATA_REFCLK needs to be modeled as a > actual clock input to the IP. You should be able to get the rate using > clk_get_rate() and make the MPY bits calculation depending on the > incoming rate. > > You should be able to model the clock even when not using common clock > framework. > > DA850 AHCI does not use a con_id at the moment (it assumes a single > clock), and that needs to change. > It's true that once davinci gets ported (is this planned?) to using the common clock framework, we could just create a fixed-clock node in da850-lcdk for the SATA oscillator, so the new property is redundant. What I don't get is how should I model a clock that is not configurable and is board-specific? Is hard-coding the relevant rate in da850.c with a huge FIXME the right way? Thanks, Bartosz Golaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
