Hi Bartlomiej, On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote: > This patchset adds m68k/Atari Falcon PATA support to libata. Thanks for your series! That leaves us with 4 to go ;-) CONFIG_BLK_DEV_GAYLE CONFIG_BLK_DEV_BUDDHA CONFIG_BLK_DEV_MAC_IDE CONFIG_BLK_DEV_Q40IDE Note that using libata instead of the legacy IDE driver increases kernel size. After enabling libata: CONFIG_ATA=y CONFIG_ATA_VERBOSE_ERROR=y CONFIG_ATA_SFF=y CONFIG_PATA_FALCON=y an atari_defconfig kernel grew by: add/remove: 775/0 grow/shrink: 753/41 up/down: 98999/-242 (98757) After disabling CONFIG_IDE: add/remove: 0/589 grow/shrink: 0/12 up/down: 0/-62835 (-62835) So the net result is: add/remove: 775/589 grow/shrink: 749/51 up/down: 98886/-62964 (35922) Disabling CONFIG_ATA_VERBOSE_ERROR saved 1380 bytes, which is less than the value advertised by Kconfig (6KB). > The major difference in the new libata's pata_falcon host > driver when compared to legacy IDE's falconide host driver is > that we are using polled PIO mode and thus avoiding the need > for STDMA locking magic altogether. I'll let the Atari experts (Michael?) comment on that... > Tested under ARAnyM emulator. Works indeed fine on ARAnyM. Unfortunately I can't test it on real hardware... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html